ethapi: Add tests for SetCodeTx type to check Call functionality #30947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1165,6 +1203,7 @@ func TestCall(t *testing.T) { | |||
| t.Errorf("test %s, result mismatch, have\n%v\n, want\n%v\n", tc.name, result.String(), tc.want) | |||
| } | |||
| } | |||
|
|
|||
| @@ -870,14 +870,15 @@ func TestCall(t *testing.T) { | |||
|
|
|||
| // Initialize test accounts | |||
| var ( | |||
| accounts = newAccounts(3) | |||
| accounts = newAccounts(7) | |||
There was a problem hiding this comment.
Why do you need 7 accounts here? afaict you only use 5
| dad = common.HexToAddress("0x0000000000000000000000000000000000000dad") | ||
| genesis = &core.Genesis{ | ||
| Config: params.MergedTestChainConfig, | ||
| Alloc: types.GenesisAlloc{ | ||
| accounts[0].addr: {Balance: big.NewInt(params.Ether)}, | ||
| accounts[1].addr: {Balance: big.NewInt(params.Ether)}, | ||
| accounts[2].addr: {Balance: big.NewInt(params.Ether)}, | ||
| accounts[3].addr: {Balance: big.NewInt(params.Ether) ,Code: append(types.DelegationPrefix, accounts[4].addr.Bytes()...)}, |
There was a problem hiding this comment.
The file needs to be goimports -ed otherwise the linter will fail
|
Right, as far as I can tell these cases test that a delegated account is still able to transfer value and call contracts as before. Fair. Tho what I had in mind was testing the new functionality a bit. One of them being: doing a call where AuthorizationsList is non-empty and it tries to delegate an account. Another interesting one is using a 3rd account to call a delegated account. |
|
Okay will surely add that ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #30920
I added tests similar that were pushed for eth_estimate gas what more tests can i add